gbili/webservice
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up some exceptions, phpdoc

Browse Source
This commit is contained in:
Gilles Crettenand
2015-06-02 22:49:44 +02:00
parent af4c9e77c8
commit 5c14ea3127
5 changed files with 104 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Lib/WebService.php
View File

@@ -74,18 +74,18 @@ abstract class WebService
$params = empty($_GET) ? $_POST : $_GET;
if (empty($params)) {
throw new UsageException("CallArgument", "arguments error", -1);
throw new UsageException("NoArguments", "No arguments specified.", UsageException::NO_ARGS);
}
if (!array_key_exists("func", $params)) {
throw new UsageException("CallArgFunction", "no 'func' specified", -2);
throw new UsageException("MissingMethod", "No method specified.", UsageException::MISSING_METHOD);
}
$this->func = $params["func"];
unset($params['func']);
if (!is_callable(array($this, $this->func))) {
throw new UsageException("CallFunction", "'func' method not available", -3);
throw new UsageException("BadMethod", "Method {$this->func} does not exists.", UsageException::BAD_METHOD);
}
$rm = new \ReflectionMethod($this, $this->func);
@@ -95,10 +95,10 @@ abstract class WebService
/* Check the number of arguments. */
if ($nbParams < $nbArgsFix) {
throw new UsageException("CallArgNumber", "you must provide at least " . $nbArgsFix . " arguments", 4);
throw new UsageException("TooManyArgs", "You must provide at least $nbArgsFix arguments.", UsageException::TOO_MANY_ARGS);
}
if ($nbParams > $nbArgs) {
throw new UsageException("CallArgNumber", "you must provide at most " . $nbArgs . " arguments", 4);
throw new UsageException("TooFewArgs", "You must provide at most $nbArgs arguments.", UsageException::TOO_FEW_ARGS);
}
$this->log("Calling '".$this->func."'");